xiangfu0 commented on code in PR #18837:
URL: https://github.com/apache/pinot/pull/18837#discussion_r3463496043
##########
config/checkstyle.xml:
##########
@@ -357,4 +357,8 @@
<property name="format" value="StringUtils\.replace\("/>
<property name="message" value="StringUtils.replace() is deprecated. Use
Strings.CS.replace() instead."/>
</module>
+ <module name="RegexpSingleline">
Review Comment:
Follow-up: added `Collections.emptySet` to the same Checkstyle guard and
agent/C7.12 docs, including method references. Empty list/set/map factories are
now all blocked in favor of `List.of()`/`Set.of()`/`Map.of()`.
`Collections.singleton*` remains allowed only for intentional null
element/key/value cases because the modern factories reject nulls.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
