goutamadwant commented on code in PR #19202:
URL: https://github.com/apache/pinot/pull/19202#discussion_r3763806193
##########
pinot-plugins/pinot-stream-ingestion/pinot-kafka-base/src/main/java/org/apache/pinot/plugin/stream/kafka/KafkaSSLUtils.java:
##########
@@ -232,6 +266,103 @@ private static Path getKeyStorePath(Properties
consumerProps) {
return Paths.get(keyStoreLocation);
}
+ private static void writeKeyStoreAtomically(Path storePath, KeyStore
keyStore, String password)
Review Comment:
Addressed this as well. I removed the unrelated atomic store replacement,
eager certificate/key parsing, and key-pair proof changes from this PR. The
remaining auto-SSL change is limited to ConfigProvider-reference preflight
before any renewal, with focused coverage for truststore, keystore, and key
passwords and rejection before mutation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
