xiangfu0 commented on PR #19202:
URL: https://github.com/apache/pinot/pull/19202#issuecomment-5324897754
One last edge worth recording before this goes in. Low severity, but it is a
silent transformation on a universal code path, so it should not live only in a
review thread.
`ConfigUtils` now unescapes any whole value matching `$${...}`. Before this
change that string had no special meaning and passed through untouched, so a
table config **already stored** with a literal value such as `$${foo}` will
quietly lose its leading `$` the first time a post-upgrade controller or server
reads it.
Realistically nobody has such a value — `$${` was never meaningful in Pinot
table configs — so I do not think this should hold the PR. But it is a behavior
change that reaches every `BaseJsonConfig`, not just Kafka `streamConfigs`, and
it happens on read with no error and no log line. Worth a mention in the
release notes, and worth a sentence in the docs branch next to the existing
rollback paragraph, which covers the forward and rollback directions but not
values that predate the feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
