xiangfu0 commented on PR #19473: URL: https://github.com/apache/pinot/pull/19473#issuecomment-5649806256
@Jackie-Jiang, whole-`FieldSpec` deduplication is already implemented in #19476 (part 5 of this stack). `ColumnMetadataImpl.extractFieldSpec()` uses a weak interner keyed by `FieldSpec.equals`/`hashCode`, so equal column definitions share one instance across segments while changed definitions remain distinct. Complex parents are excluded because their equality does not include child definitions; their eligible children are shared. That PR also documents that shared segment-derived specs must be treated as immutable and adds identity, differing-definition, and weak-reference tests. I kept that change as a separate reviewable layer and added an explicit pointer near the top of this PR description. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
