xiangfu0 commented on PR #19473: URL: https://github.com/apache/pinot/pull/19473#issuecomment-5649900935
Folded #19476 into this PR in 862528b73b so FieldSpec deduplication and value canonicalization can be reviewed together. Equal DIMENSION, METRIC, TIME, and DATE_TIME specs now share a weakly interned instance across loaded segments. COMPLEX parents remain separate because their equality does not include children; their eligible children share normally. The metadata APIs document the read-only contract. The 48 focused metadata tests pass, including equal/different definitions, shared specs across segment loads, distinct schema containers, custom STRING/JSON literals across distinct specs, and time-column identity. Spotless, Checkstyle, and license checks pass. The dependent stack was restacked to keep each optimization once; #19477 now follows #19475 and #19476 is superseded. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
