xiangfu0 commented on PR #19473: URL: https://github.com/apache/pinot/pull/19473#issuecomment-5649808165
@Jackie-Jiang Yes, sharing the whole `FieldSpec` also removes the repeated spec object. That is already implemented in follow-up #19476: equal DIMENSION, METRIC, TIME and DATE_TIME specs share one instance through a weak interner, while differing definitions remain separate. It includes tests for repeated segment loads, differing field definitions, and collection after the specs are released. COMPLEX parents are excluded because their equality does not include children; ordinary child specs are shared. The read-only contract for shared segment-derived specs is documented there. This PR handles repeated values inside and alongside the specs, including metadata-map keys and the segment time-column name. I updated the description to call out #19476 explicitly and corrected the stale base-branch description: #19473 now targets `master`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
