xiangfu0 commented on PR #19473: URL: https://github.com/apache/pinot/pull/19473#issuecomment-5651653221
Fixed the shared-mutation correctness issue in a564ed6de4. Interned specs now reject setters, detach/freeze nested TIME settings and collection aliases, and defensively copy mutable defaults. Ordinary schemas and deserialized `FieldSpec.toJsonObject()` copies remain editable. Validation: 130 SPI/metadata tests plus 6 actual SQL null-ordering cases passed; Spotless, Checkstyle and license checks passed. Regression tests cover cross-segment mutation, stable interner keys, BYTES/UUID arrays, Jackson updates and editable copies. Independent source review has no remaining findings. The fresh three-way benchmark is complete; detailed methodology and numbers are in the PR description. With G1 dedup ON, the reachable metadata graph is 39.7–42.2% smaller than base and unchanged by freezing in these fixtures. One-thread custom-default parsing is 6.1% slower than base (1.8% slower than pre-fix). GROUP BY mean latency is 2.5–3.4% higher, while SUM is 3.7–6.4% lower, with overlapping fork ranges. Nonempty BYTES/UUID getters have a measured allocation cost: 32 B/read for 16-byte defaults, or 1,040 B/read for 1 KiB defaults. This is a bounded local comparison, not a production latency or whole-server heap claim. Current-head CI is still running; local validation is separate from CI and approval. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
