xiangfu0 commented on code in PR #19894: URL: https://github.com/apache/pinot/pull/19894#discussion_r4288766907
########## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/vector/lucene99/HnswCodec.java: ########## @@ -18,21 +18,21 @@ */ package org.apache.pinot.segment.local.segment.creator.impl.vector.lucene99; -import org.apache.lucene.backward_codecs.lucene90.Lucene90PostingsFormat; import org.apache.lucene.codecs.DocValuesFormat; import org.apache.lucene.codecs.FilterCodec; import org.apache.lucene.codecs.KnnVectorsFormat; import org.apache.lucene.codecs.PointsFormat; import org.apache.lucene.codecs.PostingsFormat; +import org.apache.lucene.codecs.lucene100.Lucene100Codec; import org.apache.lucene.codecs.lucene90.Lucene90DocValuesFormat; import org.apache.lucene.codecs.lucene90.Lucene90PointsFormat; -import org.apache.lucene.codecs.lucene912.Lucene912Codec; +import org.apache.lucene.codecs.lucene912.Lucene912PostingsFormat; Review Comment: Heads-up for the next Lucene bump: `Lucene912PostingsFormat` lives in `org.apache.lucene.codecs.lucene912` (core) only in 10.0.0 — it moves to `org.apache.lucene.backward_codecs.lucene912` in 10.1.0, so this import will fail to compile when you upgrade past 10.0. Not a blocker for this PR, just worth a note so the follow-up upgrade isn't a surprise. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
