xiangfu0 commented on code in PR #19894:
URL: https://github.com/apache/pinot/pull/19894#discussion_r4290399490
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/vector/lucene99/HnswCodec.java:
##########
@@ -18,21 +18,21 @@
*/
package org.apache.pinot.segment.local.segment.creator.impl.vector.lucene99;
-import org.apache.lucene.backward_codecs.lucene90.Lucene90PostingsFormat;
import org.apache.lucene.codecs.DocValuesFormat;
import org.apache.lucene.codecs.FilterCodec;
import org.apache.lucene.codecs.KnnVectorsFormat;
import org.apache.lucene.codecs.PointsFormat;
import org.apache.lucene.codecs.PostingsFormat;
+import org.apache.lucene.codecs.lucene100.Lucene100Codec;
import org.apache.lucene.codecs.lucene90.Lucene90DocValuesFormat;
import org.apache.lucene.codecs.lucene90.Lucene90PointsFormat;
-import org.apache.lucene.codecs.lucene912.Lucene912Codec;
+import org.apache.lucene.codecs.lucene912.Lucene912PostingsFormat;
import org.apache.lucene.codecs.perfield.PerFieldDocValuesFormat;
import org.apache.lucene.codecs.perfield.PerFieldKnnVectorsFormat;
import org.apache.lucene.codecs.perfield.PerFieldPostingsFormat;
Review Comment:
Tiny nit: the class now extends the Lucene 10.0 format but the Javadoc @see
still points at the org.apache.lucene.codecs.lucene99 package. Worth updating
to lucene100 to match.
##########
pinot-segment-local/src/test/java/org/apache/pinot/segment/local/utils/LuceneIndexCompatibilityUtilsTest.java:
##########
@@ -68,9 +72,17 @@ public void tearDown()
@Test
public void testNewerFormatsIncludingOlderCreationVersion()
throws IOException {
+ if (Version.LATEST.major != 9) {
Review Comment:
This PR adds this skip (and the twins in TextIndexRollbackRecoveryTest:390
and HnswIndexRollbackTest:272), which gate the "detect a newer-format index ->
rebuild" assertions to Lucene 9. Since bumping to Lucene 10 is this PR, CI now
runs on 10 and these never execute — the recovery feature from #19900 loses its
green coverage. Worth a CI leg running these with -Dlucene.version=9.12.0, or
capturing evidence they passed green against a 9.12 build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
