xiangfu0 commented on code in PR #19894:
URL: https://github.com/apache/pinot/pull/19894#discussion_r4291360814
##########
.github/workflows/pinot_compatibility_checks.yml:
##########
@@ -191,16 +210,15 @@ jobs:
--ignore-missing-classes
done
compatibility-verifier:
+ needs: compatibility-baselines
if: github.repository == 'apache/pinot'
runs-on: ubuntu-latest
strategy:
# Changed to false in order to improve coverage using unsafe buffers
fail-fast: false
matrix:
test_suite: [ "compatibility-verifier/sample-test-suite" ]
- old_commit: [
- "release-1.5.0", "master"
- ]
+ old_commit: ${{
fromJSON(needs.compatibility-baselines.outputs.runtime_commits) }}
Review Comment:
Dropping `release-1.5.0` from this matrix removes the only coverage of
rollback to a *released* version. Since 1.5.0 ships Lucene 9.12 and can't read
the Lucene 10 indexes this PR writes, a 1.5.0 rollback is now broken and no
longer CI-tested — the only safe target is the unmerged #19900. Worth a release
note, and #19900 should land with/before this upgrade so a shippable rollback
target exists.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
