kishoreg commented on a change in pull request #4943: Adding basic null
predicate support
URL: https://github.com/apache/incubator-pinot/pull/4943#discussion_r360596039
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/realtime/impl/nullvalue/RealtimeNullValueVectorReaderWriter.java
##########
@@ -39,4 +40,9 @@ public void setNull(int docId) {
public boolean isNull(int docId) {
return _nullBitmap.contains(docId);
}
+
+ @Override
+ public ImmutableRoaringBitmap getNullBitmap() {
Review comment:
I didn't know about this. we should measure the performance impact on the
ingestion rate (due to synchronization) and query throughput (bcos to clone).
Readwrite lock will not help since its getting updated frequently.
The synchronization is not really needed since only one thread(consumer) is
updating it. clone is important.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
