codecov-io edited a comment on issue #4943: Adding basic null predicate support URL: https://github.com/apache/incubator-pinot/pull/4943#issuecomment-567776681 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4943?src=pr&el=h1) Report > Merging [#4943](https://codecov.io/gh/apache/incubator-pinot/pull/4943?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/b250439fb7f14d1217e47bfdd22f67154d0fbd6b?src=pr&el=desc) will **decrease** coverage by `0.22%`. > The diff coverage is `65.21%`. [](https://codecov.io/gh/apache/incubator-pinot/pull/4943?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #4943 +/- ## ============================================ - Coverage 56.57% 56.34% -0.23% Complexity 16 16 ============================================ Files 1176 1180 +4 Lines 62835 63068 +233 Branches 9222 9251 +29 ============================================ - Hits 35549 35538 -11 - Misses 24643 24881 +238 - Partials 2643 2649 +6 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4943?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mpl/invertedindex/RealtimeInvertedIndexReader.java](https://codecov.io/gh/apache/incubator-pinot/pull/4943/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2ludmVydGVkaW5kZXgvUmVhbHRpbWVJbnZlcnRlZEluZGV4UmVhZGVyLmphdmE=) | `100% <ø> (+3.03%)` | `0 <0> (ø)` | :arrow_down: | | [...gment/index/readers/NullValueVectorReaderImpl.java](https://codecov.io/gh/apache/incubator-pinot/pull/4943/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L2luZGV4L3JlYWRlcnMvTnVsbFZhbHVlVmVjdG9yUmVhZGVySW1wbC5qYXZh) | `100% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [.../apache/pinot/pql/parsers/pql2/ast/FilterKind.java](https://codecov.io/gh/apache/incubator-pinot/pull/4943/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9wcWwvcGFyc2Vycy9wcWwyL2FzdC9GaWx0ZXJLaW5kLmphdmE=) | `100% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...ava/org/apache/pinot/core/plan/FilterPlanNode.java](https://codecov.io/gh/apache/incubator-pinot/pull/4943/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9wbGFuL0ZpbHRlclBsYW5Ob2RlLmphdmE=) | `92% <100%> (+1.09%)` | `0 <0> (ø)` | :arrow_down: | | [.../org/apache/pinot/pql/parsers/Pql2AstListener.java](https://codecov.io/gh/apache/incubator-pinot/pull/4943/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9wcWwvcGFyc2Vycy9QcWwyQXN0TGlzdGVuZXIuamF2YQ==) | `91.82% <100%> (+2.51%)` | `0 <0> (ø)` | :arrow_down: | | [...t/pql/parsers/pql2/ast/IsNullPredicateAstNode.java](https://codecov.io/gh/apache/incubator-pinot/pull/4943/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9wcWwvcGFyc2Vycy9wcWwyL2FzdC9Jc051bGxQcmVkaWNhdGVBc3ROb2RlLmphdmE=) | `32% <32%> (ø)` | `0 <0> (?)` | | | [...e/pinot/core/common/predicate/IsNullPredicate.java](https://codecov.io/gh/apache/incubator-pinot/pull/4943/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9jb21tb24vcHJlZGljYXRlL0lzTnVsbFByZWRpY2F0ZS5qYXZh) | `66.66% <66.66%> (ø)` | `0 <0> (?)` | | | [...inot/core/common/predicate/IsNotNullPredicate.java](https://codecov.io/gh/apache/incubator-pinot/pull/4943/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9jb21tb24vcHJlZGljYXRlL0lzTm90TnVsbFByZWRpY2F0ZS5qYXZh) | `66.66% <66.66%> (ø)` | `0 <0> (?)` | | | [...rg/apache/pinot/common/request/FilterOperator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4943/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9GaWx0ZXJPcGVyYXRvci5qYXZh) | `85.18% <66.66%> (-6.12%)` | `0 <0> (ø)` | | | [...nullvalue/RealtimeNullValueVectorReaderWriter.java](https://codecov.io/gh/apache/incubator-pinot/pull/4943/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL251bGx2YWx1ZS9SZWFsdGltZU51bGxWYWx1ZVZlY3RvclJlYWRlcldyaXRlci5qYXZh) | `85.71% <66.66%> (-14.29%)` | `0 <0> (ø)` | | | ... and [40 more](https://codecov.io/gh/apache/incubator-pinot/pull/4943/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4943?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4943?src=pr&el=footer). Last update [b250439...321a07c](https://codecov.io/gh/apache/incubator-pinot/pull/4943?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
