kishoreg commented on a change in pull request #4943: Adding basic null
predicate support
URL: https://github.com/apache/incubator-pinot/pull/4943#discussion_r360588163
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/realtime/impl/nullvalue/RealtimeNullValueVectorReaderWriter.java
##########
@@ -39,4 +40,9 @@ public void setNull(int docId) {
public boolean isNull(int docId) {
return _nullBitmap.contains(docId);
}
+
+ @Override
+ public ImmutableRoaringBitmap getNullBitmap() {
Review comment:
@Jackie-Jiang why do we need that? there is only one thread updating the
bitmap and multiple threads reading it. cloning entire bitmap for every access
is going to be expensive. when did we do this change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
