icefury71 commented on a change in pull request #4995: Decouple server instance
id with hostname/port config.
URL: https://github.com/apache/incubator-pinot/pull/4995#discussion_r368160531
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/utils/CommonConstants.java
##########
@@ -192,6 +192,9 @@ public ServerType getServerType() {
public static final String CONFIG_OF_REQUEST_HANDLER_FACTORY_CLASS =
"pinot.server.requestHandlerFactory.class";
public static final String CONFIG_OF_NETTY_PORT =
"pinot.server.netty.port";
public static final String CONFIG_OF_ADMIN_API_PORT =
"pinot.server.adminapi.port";
+ // A logical instance id is one which does not contain server host name
and/or port info. E.g., server1.
+ // It is by default disabled.
+ public static final String CONFIG_OF_USE_LOGICAL_INSTANCE_ID =
"pinot.server.logical.instance.id.enabled";
Review comment:
Why do we need this ? I think we will always use the Zk info to look up host
and port (whether logical id is enabled or not).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
