chenboat commented on issue #4995: Decouple server instance id with 
hostname/port config.
URL: https://github.com/apache/incubator-pinot/pull/4995#issuecomment-578911613
 
 
   > Done. Now if the server config has both instance id and host/port, the 
host/port info in zk will be overwritten with the config values. If the server 
config only has instance id, the behavior remains as it is now.
   > 
   > > I would recommend to always override host and port if they are provided 
through config instead of introducing an extra config
   
   @Jackie-Jiang Jackie, could you pls take another look at this PR? Thanks.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to