Jackie-Jiang commented on a change in pull request #4995: Decouple server
instance id with hostname/port config.
URL: https://github.com/apache/incubator-pinot/pull/4995#discussion_r371455558
##########
File path:
pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixServerStarter.java
##########
@@ -186,6 +194,16 @@ public HelixServerStarter(String helixClusterName, String
zkServer, Configuratio
serverMetrics.addCallbackGauge("memory.allocationFailureCount",
PinotDataBuffer::getAllocationFailureCount);
}
+ private void overwriteServerHostInfo() {
Review comment:
Can you combine this with `addInstanceTagIfNeeded()` as both of them need to
access the `InstanceConfig` to reduce the overhead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
