codecov-io edited a comment on issue #4995: Decouple server instance id with hostname/port config. URL: https://github.com/apache/incubator-pinot/pull/4995#issuecomment-575972107 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4995?src=pr&el=h1) Report > Merging [#4995](https://codecov.io/gh/apache/incubator-pinot/pull/4995?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/29c6b39d34d51bb4165b0be63b17a427a45ebf52?src=pr&el=desc) will **increase** coverage by `5.54%`. > The diff coverage is `54.09%`. [](https://codecov.io/gh/apache/incubator-pinot/pull/4995?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #4995 +/- ## ============================================ + Coverage 51.82% 57.37% +5.54% ============================================ Files 1176 1178 +2 Lines 62388 62628 +240 Branches 9167 9202 +35 ============================================ + Hits 32331 35931 +3600 + Misses 27577 24019 -3558 - Partials 2480 2678 +198 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4995?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...org/apache/pinot/common/utils/CommonConstants.java](https://codecov.io/gh/apache/incubator-pinot/pull/4995/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdXRpbHMvQ29tbW9uQ29uc3RhbnRzLmphdmE=) | `34% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...inot/spi/ingestion/batch/IngestionJobLauncher.java](https://codecov.io/gh/apache/incubator-pinot/pull/4995/diff?src=pr&el=tree#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvaW5nZXN0aW9uL2JhdGNoL0luZ2VzdGlvbkpvYkxhdW5jaGVyLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...ingestion/batch/common/SegmentGenerationUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/4995/diff?src=pr&el=tree#diff-cGlub3QtcGx1Z2lucy9waW5vdC1iYXRjaC1pbmdlc3Rpb24vcGlub3QtYmF0Y2gtaW5nZXN0aW9uLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvcGx1Z2luL2luZ2VzdGlvbi9iYXRjaC9jb21tb24vU2VnbWVudEdlbmVyYXRpb25VdGlscy5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...lugin/ingestion/batch/common/SegmentPushUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/4995/diff?src=pr&el=tree#diff-cGlub3QtcGx1Z2lucy9waW5vdC1iYXRjaC1pbmdlc3Rpb24vcGlub3QtYmF0Y2gtaW5nZXN0aW9uLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvcGx1Z2luL2luZ2VzdGlvbi9iYXRjaC9jb21tb24vU2VnbWVudFB1c2hVdGlscy5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...he/pinot/tools/admin/command/QuickstartRunner.java](https://codecov.io/gh/apache/incubator-pinot/pull/4995/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL2FkbWluL2NvbW1hbmQvUXVpY2tzdGFydFJ1bm5lci5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...not/controller/api/resources/PqlQueryResource.java](https://codecov.io/gh/apache/incubator-pinot/pull/4995/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9hcGkvcmVzb3VyY2VzL1BxbFF1ZXJ5UmVzb3VyY2UuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...ava/org/apache/pinot/spi/plugin/PluginManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4995/diff?src=pr&el=tree#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvcGx1Z2luL1BsdWdpbk1hbmFnZXIuamF2YQ==) | `33.33% <0%> (-1.12%)` | `0 <0> (ø)` | | | [.../pinot/broker/broker/helix/HelixBrokerStarter.java](https://codecov.io/gh/apache/incubator-pinot/pull/4995/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYnJva2VyL2hlbGl4L0hlbGl4QnJva2VyU3RhcnRlci5qYXZh) | `68.66% <100%> (+1.08%)` | `0 <0> (ø)` | :arrow_down: | | [...ot/controller/helix/core/util/HelixSetupUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/4995/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL3V0aWwvSGVsaXhTZXR1cFV0aWxzLmphdmE=) | `88.88% <100%> (+0.13%)` | `0 <0> (ø)` | :arrow_down: | | [...pinot/server/starter/helix/HelixServerStarter.java](https://codecov.io/gh/apache/incubator-pinot/pull/4995/diff?src=pr&el=tree#diff-cGlub3Qtc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zZXJ2ZXIvc3RhcnRlci9oZWxpeC9IZWxpeFNlcnZlclN0YXJ0ZXIuamF2YQ==) | `49.28% <100%> (+49.28%)` | `0 <0> (ø)` | :arrow_down: | | ... and [222 more](https://codecov.io/gh/apache/incubator-pinot/pull/4995/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4995?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4995?src=pr&el=footer). Last update [29c6b39...f87cd46](https://codecov.io/gh/apache/incubator-pinot/pull/4995?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
