siddharthteotia commented on a change in pull request #6926:
URL: https://github.com/apache/incubator-pinot/pull/6926#discussion_r633824307
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/recommender/realtime/provisioning/MemoryEstimator.java
##########
@@ -127,26 +124,21 @@ public MemoryEstimator(TableConfig tableConfig, File
sampleCompletedSegment, int
_invertedIndexColumns.addAll(_tableConfig.getIndexingConfig().getInvertedIndexColumns());
}
_avgMultiValues = getAvgMultiValues();
-
- _tableDataDir = new File(TMP_DIR, _tableNameWithType);
- try {
- FileUtils.deleteDirectory(_tableDataDir);
- } catch (IOException e) {
- throw new RuntimeException("Exception in deleting directory " +
_tableDataDir.getAbsolutePath(), e);
- }
- _tableDataDir.mkdir();
+ _workingDir = workingDir;
}
/**
* Constructor used for processing the given data characteristics (instead
of completed segment)
*/
public MemoryEstimator(TableConfig tableConfig, Schema schema,
SchemaWithMetaData schemaWithMetadata,
- int numberOfRows, int ingestionRatePerPartition, long
maxUsableHostMemory, int tableRetentionHours) {
+ int numberOfRows, int ingestionRatePerPartition, long
maxUsableHostMemory, int tableRetentionHours,
+ File workingDir) {
Review comment:
(nit) please add brief javadoc on how this workingDir is used
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
