siddharthteotia commented on a change in pull request #6926:
URL: https://github.com/apache/incubator-pinot/pull/6926#discussion_r633826212
##########
File path:
pinot-controller/src/test/java/org/apache/pinot/controller/recommender/realtime/provisioning/MemoryEstimatorTest.java
##########
@@ -116,7 +117,7 @@ private void runTest(String schemaFileName,
Consumer<String> assertFunc) throws
assertFunc.accept(metadata);
// cleanup
- FileUtils.deleteDirectory(generatedSegment);
+ FileUtils.deleteDirectory(workingDir);
Review comment:
The test should not have to do this. The estimator should internally
delete the directory right since everything it generates is transient?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
