siddharthteotia commented on a change in pull request #6926:
URL: https://github.com/apache/incubator-pinot/pull/6926#discussion_r633846114
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/recommender/realtime/provisioning/MemoryEstimator.java
##########
@@ -430,44 +422,48 @@ private long
calculateMemoryForCompletedSegmentsPerPartition(long completedSegme
return _numSegmentsQueriedPerHost;
}
+ public void cleanup() {
Review comment:
+1
In any case we need to make the cleanup private so that user of
MemoryEstimator should not worry about the protocol of cleaning up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
