siddharthteotia commented on a change in pull request #6926:
URL: https://github.com/apache/incubator-pinot/pull/6926#discussion_r633828184



##########
File path: 
pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/RealtimeProvisioningHelperCommand.java
##########
@@ -278,6 +280,7 @@ public boolean execute()
     displayResults(memoryEstimator.getConsumingMemoryPerHost(), numHosts, 
numHours);
     LOGGER.info("\nTotal number of segments queried per host (for all 
partitions)");
     displayResults(memoryEstimator.getNumSegmentsQueriedPerHost(), numHosts, 
numHours);
+    memoryEstimator.cleanup();

Review comment:
       Let's not make this an exposed API. The estimator should do the correct 
thing and everything that is necessary to ensure cleanup




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to