sajjad-moradi commented on a change in pull request #6926:
URL: https://github.com/apache/incubator-pinot/pull/6926#discussion_r633900014
##########
File path:
pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/RealtimeProvisioningHelperCommand.java
##########
@@ -278,6 +280,7 @@ public boolean execute()
displayResults(memoryEstimator.getConsumingMemoryPerHost(), numHosts,
numHours);
LOGGER.info("\nTotal number of segments queried per host (for all
partitions)");
displayResults(memoryEstimator.getNumSegmentsQueriedPerHost(), numHosts,
numHours);
+ memoryEstimator.cleanup();
Review comment:
Good point. I agree.
Note that there are two ways segments are generated:
1. Directly from SegmentGenerator.generate()
2. Implicitly in MemoryEstimator.estimateMemory()
For case 2, as you mentioned, we should clean it automatically and not
delegate that to the caller of estimateMemory.
For case 1, it's up to the caller if they want to keep or delete the
generated segment. So SegmentGenerator doesn't delete the segment automatically.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
