jtao15 commented on a change in pull request #7516:
URL: https://github.com/apache/pinot/pull/7516#discussion_r721808892



##########
File path: 
pinot-minion/src/main/java/org/apache/pinot/minion/BaseMinionStarter.java
##########
@@ -102,7 +102,12 @@ public void init(PinotConfiguration config)
     setupHelixSystemProperties();
     _helixManager = new ZKHelixManager(helixClusterName, _instanceId, 
InstanceType.PARTICIPANT, zkAddress);
     MinionTaskZkMetadataManager minionTaskZkMetadataManager = new 
MinionTaskZkMetadataManager(_helixManager);
-    _taskExecutorFactoryRegistry = new 
TaskExecutorFactoryRegistry(minionTaskZkMetadataManager);
+    int endReplaceSegmentsSocketTimeoutMs =
+        
_config.getProperty(CommonConstants.Minion.END_REPLACE_SEGMENTS_SOCKET_TIMEOUT_MS_KEY)
 != null

Review comment:
       Good point, using the getOrDefault function instead.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to