jtao15 commented on a change in pull request #7516:
URL: https://github.com/apache/pinot/pull/7516#discussion_r724580809



##########
File path: 
pinot-minion/src/main/java/org/apache/pinot/minion/executor/MinionTaskZkMetadataManager.java
##########
@@ -31,9 +31,11 @@
  */
 public class MinionTaskZkMetadataManager {
   private final HelixManager _helixManager;
+  private final int _endReplaceSegmentsSocketTimeoutMs;
 
-  public MinionTaskZkMetadataManager(HelixManager helixManager) {
+  public MinionTaskZkMetadataManager(HelixManager helixManager, int 
endReplaceSegmentsSocketTimeoutMs) {

Review comment:
       As discussed offline, based on the definition, the minion configs should 
not be maintained by this class. Moved the config into 
`BaseMultipleSegmentsConversionExecutor` class. Added new init function in 
`PinotTaskExecutorFactory` to make it backward compatible.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to