jtao15 commented on a change in pull request #7516:
URL: https://github.com/apache/pinot/pull/7516#discussion_r724581590
##########
File path:
pinot-minion/src/main/java/org/apache/pinot/minion/BaseMinionStarter.java
##########
@@ -101,7 +101,11 @@ public void init(PinotConfiguration config)
_listenerConfigs = ListenerConfigUtil.buildMinionAdminConfigs(_config);
setupHelixSystemProperties();
_helixManager = new ZKHelixManager(helixClusterName, _instanceId,
InstanceType.PARTICIPANT, zkAddress);
- MinionTaskZkMetadataManager minionTaskZkMetadataManager = new
MinionTaskZkMetadataManager(_helixManager);
+ int endReplaceSegmentsSocketTimeoutMs =
+
_config.getProperty(CommonConstants.Minion.END_REPLACE_SEGMENTS_SOCKET_TIMEOUT_MS_KEY,
+
CommonConstants.Minion.DEFAULT_END_REPLACE_SEGMENTS_SOCKET_TIMEOUT_MS);
+ MinionTaskZkMetadataManager minionTaskZkMetadataManager =
+ new MinionTaskZkMetadataManager(_helixManager,
endReplaceSegmentsSocketTimeoutMs);
Review comment:
Good point! This is also mentioned by @snleee offline. Created the new
`MinionConf` class instead. Based on the definition of
`MinionTaskZkMetadataManager`, moved the configs out of this class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]