snleee commented on a change in pull request #7516:
URL: https://github.com/apache/pinot/pull/7516#discussion_r721783593



##########
File path: 
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java
##########
@@ -429,6 +429,8 @@ private CommonConstants() {
     // Config keys
     public static final String CONFIG_OF_METRICS_PREFIX_KEY = "metricsPrefix";
     public static final String METRICS_REGISTRY_REGISTRATION_LISTENERS_KEY = 
"metricsRegistryRegistrationListeners";
+    public static final String END_REPLACE_SEGMENTS_SOCKET_TIMEOUT_MS_KEY =

Review comment:
       let's call this as 
   
   `END_REPLACE_SEGMENTS_TIMEOUT_MS_KEY`

##########
File path: 
pinot-minion/src/main/java/org/apache/pinot/minion/executor/MinionTaskZkMetadataManager.java
##########
@@ -31,9 +31,11 @@
  */
 public class MinionTaskZkMetadataManager {
   private final HelixManager _helixManager;
+  private final int _endReplaceSegmentsSocketTimeoutMs;
 
-  public MinionTaskZkMetadataManager(HelixManager helixManager) {
+  public MinionTaskZkMetadataManager(HelixManager helixManager, int 
endReplaceSegmentsSocketTimeoutMs) {

Review comment:
       +1 that we should not change the interface. However, adding this config 
to `MinionTaskZkMetadataManager` looks like a hacky solution to me. 
   Here's the class definition.
   ```
    * An abstraction on top of {@link HelixManager}, created for the {@link 
PinotTaskExecutor}, restricted to only
    * get/update minion task metadata
   ``` 
   
   Let's brainstorm the better way (e.g. add the new method instead of changing 
the interface)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to