siddharthteotia commented on a change in pull request #7898:
URL: https://github.com/apache/pinot/pull/7898#discussion_r768286167
##########
File path:
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/columnminmaxvalue/ColumnMinMaxValueGenerator.java
##########
@@ -56,6 +56,34 @@ public ColumnMinMaxValueGenerator(SegmentMetadataImpl
segmentMetadata, SegmentDi
_columnMinMaxValueGeneratorMode = columnMinMaxValueGeneratorMode;
}
+ public boolean needAddColumnMinMaxValue() {
+ Schema schema = _segmentMetadata.getSchema();
+ Set<String> columnsToAddMinMaxValue = new
HashSet<>(schema.getPhysicalColumnNames());
Review comment:
Will the code duplication be fixed up in follow-up PR (when the flow is
actually changed) where this logic of "whether update is needed or not" is
removed from `addColumnMinMaxValue`() function and latter will simply add ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
