siddharthteotia commented on a change in pull request #7898:
URL: https://github.com/apache/pinot/pull/7898#discussion_r768290777
##########
File path:
pinot-segment-local/src/test/java/org/apache/pinot/segment/local/segment/index/loader/SegmentPreProcessorTest.java
##########
@@ -1080,4 +1073,129 @@ public void testV3CleanupH3AndTextIndices()
}
assertEquals(singleFileIndex.length(), initFileSize);
}
+
+ @Test
+ public void testV1IfNeedProcess()
+ throws Exception {
+ constructV1Segment();
+ SegmentMetadataImpl segmentMetadata = new SegmentMetadataImpl(_indexDir);
+ assertEquals(segmentMetadata.getVersion(), SegmentVersion.v1);
+
+ testIfNeedProcess();
Review comment:
Also add a test where V1 segment has to be preprocessed because
IndexLoadingConfig has segmentVersion has V3 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
