siddharthteotia commented on a change in pull request #7898:
URL: https://github.com/apache/pinot/pull/7898#discussion_r768288135
##########
File path:
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/defaultcolumn/DefaultColumnHandler.java
##########
@@ -28,4 +28,10 @@
*/
void updateDefaultColumns()
throws Exception;
+
+ /**
Review comment:
(nit) The comment is a bit misleading. The DefaultColumnHandler also
adds new column(s) with the default value and fwd index, dictionary if the
schema has extra column(s) but segment disk metadata doesn't have them. In
addition to this, yes the default value of auto-generated columns can also be
updated by the handler if need be as you mentioned in javadoc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
