klsince commented on a change in pull request #7898:
URL: https://github.com/apache/pinot/pull/7898#discussion_r768376148
##########
File path:
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/columnminmaxvalue/ColumnMinMaxValueGenerator.java
##########
@@ -56,6 +56,34 @@ public ColumnMinMaxValueGenerator(SegmentMetadataImpl
segmentMetadata, SegmentDi
_columnMinMaxValueGeneratorMode = columnMinMaxValueGeneratorMode;
}
+ public boolean needAddColumnMinMaxValue() {
+ Schema schema = _segmentMetadata.getSchema();
+ Set<String> columnsToAddMinMaxValue = new
HashSet<>(schema.getPhysicalColumnNames());
Review comment:
will remove some duplicate code here firstly.
> ... addColumnMinMaxValue() function and latter will simply add?
Probably not (if I understand this question correctly). Because that would
require the needProcess() to check all conditions and collect what's to be
added/removed/updated and pass that info to process() method later on. To begin
with, needProcess() returns a boolean, and stops as soon as it finds a need for
process, for simplicity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
