jadami10 commented on a change in pull request #7892:
URL: https://github.com/apache/pinot/pull/7892#discussion_r771097137
##########
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BaseBrokerStarter.java
##########
@@ -85,6 +85,8 @@
protected String _hostname;
protected int _port;
protected String _instanceId;
+ private boolean _isStarting = false;
Review comment:
good point, forgot this gets called from all the server threads too
##########
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/PinotBrokerHealthCheck.java
##########
@@ -61,7 +61,9 @@ public String getBrokerHealth() {
return "OK";
}
_brokerMetrics.addMeteredGlobalValue(BrokerMeter.HEALTHCHECK_BAD_CALLS, 1);
- throw new WebApplicationException(String.format("Pinot broker status is
%s", status),
- Response.Status.SERVICE_UNAVAILABLE);
+ Response response =
Review comment:
maybe you can test locally as well, but I don't get the error message
back on curl with the original code. There's several questions on SO about
this, but
https://stackoverflow.com/questions/45952171/webapplicationexception-is-not-showing-the-error-message
has the best example
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
