Jackie-Jiang commented on a change in pull request #7892:
URL: https://github.com/apache/pinot/pull/7892#discussion_r771738964
##########
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/PinotBrokerHealthCheck.java
##########
@@ -61,7 +61,9 @@ public String getBrokerHealth() {
return "OK";
}
_brokerMetrics.addMeteredGlobalValue(BrokerMeter.HEALTHCHECK_BAD_CALLS, 1);
- throw new WebApplicationException(String.format("Pinot broker status is
%s", status),
- Response.Status.SERVICE_UNAVAILABLE);
+ Response response =
Review comment:
I tried both constructors, and seems the new one will change the message
to `"HTTP 503 Service Unavailable"` and encode the actual error message as the
entity of the response. Changing the response format can potentially cause
backward incompatibility.
@xiangfu0 Do you have some idea on this issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
