jadami10 commented on a change in pull request #7892:
URL: https://github.com/apache/pinot/pull/7892#discussion_r784500856
##########
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/PinotBrokerHealthCheck.java
##########
@@ -61,7 +61,9 @@ public String getBrokerHealth() {
return "OK";
}
_brokerMetrics.addMeteredGlobalValue(BrokerMeter.HEALTHCHECK_BAD_CALLS, 1);
- throw new WebApplicationException(String.format("Pinot broker status is
%s", status),
- Response.Status.SERVICE_UNAVAILABLE);
+ Response response =
Review comment:
ok, i gave it one more go. if you think it should still go in a separate
PR, happy to go back to the original code.
thank you for pointing me to the debugger. this new approach keeps the same
detailMessage but updates the response to set the entity. This way you get the
actual string message when using `curl`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
