Jackie-Jiang commented on a change in pull request #7892:
URL: https://github.com/apache/pinot/pull/7892#discussion_r784424864
##########
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/PinotBrokerHealthCheck.java
##########
@@ -61,7 +61,9 @@ public String getBrokerHealth() {
return "OK";
}
_brokerMetrics.addMeteredGlobalValue(BrokerMeter.HEALTHCHECK_BAD_CALLS, 1);
- throw new WebApplicationException(String.format("Pinot broker status is
%s", status),
- Response.Status.SERVICE_UNAVAILABLE);
+ Response response =
Review comment:
Here is the properties of the exception built from the 2 constructors.
`exception1` is from the existing code, `exception2` is from the new code. Note
that the `detailedMessages` is changed, and the new one has entity embedded.
I'd suggest keeping the existing behavior for consistency. If we do need to
change the behavior, we should change it for all usages instead of just this
one (probably in a separate PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
