siddharthteotia commented on code in PR #8880:
URL: https://github.com/apache/pinot/pull/8880#discussion_r894860128
##########
pinot-common/src/test/java/org/apache/pinot/sql/parsers/CalciteSqlCompilerTest.java:
##########
@@ -698,22 +698,29 @@ public void testQueryOptions() {
Assert.assertNull(pinotQuery.getQueryOptions());
pinotQuery = CalciteSqlParser.compileToPinotQuery(
- "select * from vegetables where name <> 'Brussels sprouts' OPTION
(delicious=yes)");
+ "OPTION (delicious='yes'); select * from vegetables where name <>
'Brussels sprouts'");
Review Comment:
Can we also add tests using examples called out in
https://blog.doyensec.com/2022/06/09/apache-pinot-sqli-rce.html#query-options.
Since they now don't fit in the grammar, we can check if they fail ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
