siddharthteotia commented on code in PR #8880:
URL: https://github.com/apache/pinot/pull/8880#discussion_r894860941
##########
pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java:
##########
@@ -116,30 +101,51 @@ public static SqlNodeAndOptions
compileToSqlNodeAndOptions(String sql)
// Remove the terminating semicolon from the query
sql = removeTerminatingSemicolon(sql);
- // Extract OPTION statements from sql as Calcite Parser doesn't parse it.
- List<String> options = extractOptionsFromSql(sql);
- if (!options.isEmpty()) {
- sql = removeOptionsFromSql(sql);
- }
-
try (StringReader inStream = new StringReader(sql)) {
SqlParserImpl sqlParser = newSqlParser(inStream);
- return new SqlNodeAndOptions(sqlParser.parseSqlStmtEof(), options);
+ SqlNodeList sqlNodeList = sqlParser.SqlStmtsEof();
+ // Extract OPTION statements from sql.
+ return extractSqlNodeAndOptions(sqlNodeList);
} catch (Throwable e) {
throw new SqlCompilationException("Caught exception while parsing query:
" + sql, e);
}
}
- public static PinotSqlType extractSqlType(SqlNode sqlNode) {
- switch (sqlNode.getKind()) {
- case OTHER_DDL:
- if (sqlNode instanceof SqlInsertFromFile) {
- return PinotSqlType.DML;
+ public static SqlNodeAndOptions extractSqlNodeAndOptions(SqlNodeList
sqlNodeList) {
+ PinotSqlType sqlType = null;
+ SqlNode statementNode = null;
+ Map<String, String> options = new HashMap<>();
+ for (SqlNode sqlNode : sqlNodeList) {
Review Comment:
Let's add one or two tests that verify that exception is thrown ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
