walterddr commented on code in PR #8880:
URL: https://github.com/apache/pinot/pull/8880#discussion_r895030456
##########
pinot-common/src/main/codegen/includes/parserImpls.ftl:
##########
@@ -73,7 +73,74 @@ SqlInsertFromFile SqlInsertFromFile() :
}
}
-/* define the rest of the sql into SqlStmtList
+
+/**
Review Comment:
yeah it is already enforces by this syntatic requirement
```
StatementList:
Statement [; Statement]*
Statement:
SELECT_STATEMENT | OPTION_STATEMENT | INSERT_STATEMENT
```
because we only allow 1 executable statement inside one SQL string. the
OPTION statement can only be at the front or back. do you think this syntatic
structure is clear enough to be part of the parser.jj comment/doc? (I will add
it to the section if so)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
