walterddr commented on code in PR #8880:
URL: https://github.com/apache/pinot/pull/8880#discussion_r895030576
##########
pinot-common/src/test/java/org/apache/pinot/sql/parsers/CalciteSqlCompilerTest.java:
##########
@@ -698,22 +698,29 @@ public void testQueryOptions() {
Assert.assertNull(pinotQuery.getQueryOptions());
pinotQuery = CalciteSqlParser.compileToPinotQuery(
- "select * from vegetables where name <> 'Brussels sprouts' OPTION
(delicious=yes)");
+ "OPTION (delicious='yes'); select * from vegetables where name <>
'Brussels sprouts'");
Review Comment:
oh yes absolutely. I will check
##########
pinot-common/src/test/java/org/apache/pinot/sql/parsers/CalciteSqlCompilerTest.java:
##########
@@ -698,22 +698,29 @@ public void testQueryOptions() {
Assert.assertNull(pinotQuery.getQueryOptions());
pinotQuery = CalciteSqlParser.compileToPinotQuery(
- "select * from vegetables where name <> 'Brussels sprouts' OPTION
(delicious=yes)");
+ "OPTION (delicious='yes'); select * from vegetables where name <>
'Brussels sprouts'");
Review Comment:
oh yes absolutely. I will add to the test set
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
