npawar commented on code in PR #8941:
URL: https://github.com/apache/pinot/pull/8941#discussion_r902170670
##########
pinot-controller/src/main/resources/package-lock.json:
##########
@@ -12,14 +12,6 @@
"@babel/highlight": "^7.16.7"
}
},
- "@babel/helper-module-imports": {
Review Comment:
revert this file?
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java:
##########
@@ -585,6 +586,7 @@ private BrokerResponseNative handleRequest(long requestId,
String query, JsonNod
brokerResponse.setTimeUsedMs(totalTimeMs);
requestContext.setQueryProcessingTime(totalTimeMs);
augmentStatistics(requestContext, brokerResponse);
+ _brokerMetrics.setValueOfTableGauge(rawTableName,
BrokerGauge.QUERY_TOTAL_TIME_MS, totalTimeMs);
Review Comment:
should this be a BrokerQueryPhase (in addition to Gauge) so we can get the
percentiles, average etc?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
