navina commented on code in PR #8941:
URL: https://github.com/apache/pinot/pull/8941#discussion_r902217883
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java:
##########
@@ -585,6 +586,7 @@ private BrokerResponseNative handleRequest(long requestId,
String query, JsonNod
brokerResponse.setTimeUsedMs(totalTimeMs);
requestContext.setQueryProcessingTime(totalTimeMs);
augmentStatistics(requestContext, brokerResponse);
+ _brokerMetrics.setValueOfTableGauge(rawTableName,
BrokerGauge.QUERY_TOTAL_TIME_MS, totalTimeMs);
Review Comment:
yeah. I wasn't sure if this falls under the "query phase" metrics as it
seemed to be applicable for each stage. I don't think percentiles/average etc
are related to `BrokerQueryPhase`, but rather to the metric type itself ?
Please correct me if I have misunderstood. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
