navina commented on code in PR #8941:
URL: https://github.com/apache/pinot/pull/8941#discussion_r904289245
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java:
##########
@@ -585,6 +586,7 @@ private BrokerResponseNative handleRequest(long requestId,
String query, JsonNod
brokerResponse.setTimeUsedMs(totalTimeMs);
requestContext.setQueryProcessingTime(totalTimeMs);
augmentStatistics(requestContext, brokerResponse);
+ _brokerMetrics.setValueOfTableGauge(rawTableName,
BrokerGauge.QUERY_TOTAL_TIME_MS, totalTimeMs);
Review Comment:
`Timer` has rates and distribution stats. `Gauges` don't.
(https://metrics.dropwizard.io/4.2.0/getting-started.html#timers)[https://metrics.dropwizard.io/4.2.0/getting-started.html#timers]
I also verified the metrics locally - it is seen in mbeans and getting
published to prometheus.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
