npawar commented on code in PR #8941:
URL: https://github.com/apache/pinot/pull/8941#discussion_r904210332
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java:
##########
@@ -585,6 +586,7 @@ private BrokerResponseNative handleRequest(long requestId,
String query, JsonNod
brokerResponse.setTimeUsedMs(totalTimeMs);
requestContext.setQueryProcessingTime(totalTimeMs);
augmentStatistics(requestContext, brokerResponse);
+ _brokerMetrics.setValueOfTableGauge(rawTableName,
BrokerGauge.QUERY_TOTAL_TIME_MS, totalTimeMs);
Review Comment:
just thought it makes more sense here, as all the phases are here, and some
of them are already supersets of the others. And now this one is the ultimate
superset:
```
REQUEST_COMPILATION,
QUERY_EXECUTION,
QUERY_ROUTING,
SCATTER_GATHER,
DESERIALIZATION,
```
We do see the aggregations applied to these afaik..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
