walterddr commented on code in PR #9887:
URL: https://github.com/apache/pinot/pull/9887#discussion_r1041158969
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/mailbox/GrpcReceivingMailbox.java:
##########
@@ -123,6 +124,11 @@ private TransferableBlock
fromMailboxContent(MailboxContent mailboxContent)
return new TransferableBlock(dataBlock);
}
}
+
+ if
(mailboxContent.getMetadataOrDefault(ChannelUtils.MAILBOX_METADATA_END_OF_STREAM_KEY,
"false").equals("true")) {
+ return TransferableBlockUtils.getEndOfStreamTransferableBlock();
+ }
Review Comment:
any idea why this wasn't causing any trouble until now? as i can see
InMemoryReceivingMailbox seems to return the EOS block correctly all along
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
