walterddr commented on PR #9912: URL: https://github.com/apache/pinot/pull/9912#issuecomment-1343063133
> @walterddr I'm not sure I agree with the concerns - for the first this will still work just fine; the second makes sense because SQL supports case-sensitivity (generally they would require you to quote case sensitive names, but at least it's supported). I've never seen a configuration system with case sensitive configs. It's kind of like requiring the SQL keywords to be case sensitive (e.g. `SELECT *` would work but `select *` wouldn't) sound good. as long as we limited the list of case insensitive options to the known ones in `QueryOptionKey` --> which seems logical compare to the `SELECT *` vs. `select *` analogy (reserved keywords are always case insensitive) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
