walterddr commented on code in PR #9912:
URL: https://github.com/apache/pinot/pull/9912#discussion_r1043659579
##########
pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java:
##########
@@ -171,7 +172,7 @@ static SqlNodeAndOptions extractSqlNodeAndOptions(String
sql, SqlNodeList sqlNod
if (sqlType == null) {
throw new SqlCompilationException("SqlNode with executable statement not
found!");
}
- return new SqlNodeAndOptions(statementNode, sqlType, options);
+ return new SqlNodeAndOptions(statementNode, sqlType,
QueryOptionsUtils.resolveCaseInsensitiveOptions(options));
Review Comment:
e.g. also test
1. JSON option `timeoutMs = 60000`
2. query option `OPTION(timeoutMs=30000)`
3. query set `SET timeoutMs = 20000`
4. implicitly there's a default 10000
let's make sure the combination of these result in the same final timeout
number
- by setting 1,2,3 to `timeoutms` or `TIMEOUTMS` or `timeoutMs`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
