walterddr commented on code in PR #9912:
URL: https://github.com/apache/pinot/pull/9912#discussion_r1043641469
##########
pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java:
##########
@@ -171,7 +172,7 @@ static SqlNodeAndOptions extractSqlNodeAndOptions(String
sql, SqlNodeList sqlNod
if (sqlType == null) {
throw new SqlCompilationException("SqlNode with executable statement not
found!");
}
- return new SqlNodeAndOptions(statementNode, sqlType, options);
+ return new SqlNodeAndOptions(statementNode, sqlType,
QueryOptionsUtils.resolveCaseInsensitiveOptions(options));
Review Comment:
it should be fine. but let's make sure to test when the other 2 ways to
configure options are present - and what the desired behavior is - and that
should match the behavior of current logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
