agavra commented on code in PR #9912:
URL: https://github.com/apache/pinot/pull/9912#discussion_r1043636548
##########
pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java:
##########
@@ -171,7 +172,7 @@ static SqlNodeAndOptions extractSqlNodeAndOptions(String
sql, SqlNodeList sqlNod
if (sqlType == null) {
throw new SqlCompilationException("SqlNode with executable statement not
found!");
}
- return new SqlNodeAndOptions(statementNode, sqlType, options);
+ return new SqlNodeAndOptions(statementNode, sqlType,
QueryOptionsUtils.resolveCaseInsensitiveOptions(options));
Review Comment:
I considered both of these and thought it was OK to make this a partial
improvement. the SET syntax is particularly misleading given that it "feels"
like sql - if we feel strongly about it I can attempt to wire this in through
the other places as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
