ImprovingRichard commented on code in PR #10292:
URL: https://github.com/apache/pinot/pull/10292#discussion_r1112037934
##########
pinot-clients/pinot-jdbc-client/src/main/java/org/apache/pinot/client/PinotPreparedStatement.java:
##########
@@ -51,7 +51,7 @@ public PinotPreparedStatement(PinotConnection connection,
String query) {
if (!DriverUtils.queryContainsLimitStatement(_query)) {
_query += " " + LIMIT_STATEMENT + " " + _maxRows;
}
- _query = DriverUtils.enableNullHandling(_connection, _query);
+ _query = _connection.enableQueryOptions(_query);
Review Comment:
V1 vs V2 is controlled by an option as well as the cluster config.
QueryOptionKey.USE_MULTISTAGE_ENGINE is an existing key.
I did consider whether this is useful long term because I'm not sure if the
intent is to support both versions in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
