ImprovingRichard commented on code in PR #10292:
URL: https://github.com/apache/pinot/pull/10292#discussion_r1112041186
##########
pinot-clients/pinot-jdbc-client/src/main/java/org/apache/pinot/client/PinotConnection.java:
##########
@@ -67,15 +74,24 @@ public class PinotConnection extends AbstractBaseConnection
{
}
_session = new org.apache.pinot.client.Connection(properties, brokers,
transport);
- _enableNullHandling =
Boolean.parseBoolean(properties.getProperty(QueryOptionKey.ENABLE_NULL_HANDLING));
+ for (String possibleQueryOption: POSSIBLE_QUERY_OPTIONS) {
Review Comment:
With this implementation, to support new query options, an entry per option
is added to the POSSIBLE_QUERY_OPTIONS array. All other code remains the same.
It also keeps the filtering of query options to the connection creation instead
of having to do it per statement execution. It also keeps from having to hash
into the options to get the enable flag per statement execution.
I'm not sure how backward compatibility comes into play.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
