ImprovingRichard commented on code in PR #10292:
URL: https://github.com/apache/pinot/pull/10292#discussion_r1112031843
##########
pinot-clients/pinot-jdbc-client/src/main/java/org/apache/pinot/client/PinotConnection.java:
##########
@@ -67,15 +74,24 @@ public class PinotConnection extends AbstractBaseConnection
{
}
_session = new org.apache.pinot.client.Connection(properties, brokers,
transport);
- _enableNullHandling =
Boolean.parseBoolean(properties.getProperty(QueryOptionKey.ENABLE_NULL_HANDLING));
+ for (String possibleQueryOption: POSSIBLE_QUERY_OPTIONS) {
+ _queryOptions.put(possibleQueryOption,
Boolean.parseBoolean(properties.getProperty(possibleQueryOption)));
+ }
}
public org.apache.pinot.client.Connection getSession() {
return _session;
}
- public boolean isNullHandlingEnabled() {
- return _enableNullHandling;
+ protected String enableQueryOptions(String sql) {
+ StringBuilder optionsBuilder = new StringBuilder();
+ for (HashMap.Entry<String, Boolean> optionEntry: _queryOptions.entrySet())
{
+ if (optionEntry.getValue() && !sql.contains(optionEntry.getKey())) {
+
optionsBuilder.append(DriverUtils.createSetQueryOptionString(optionEntry.getKey()));
Review Comment:
Can you clarify? DriverUtils.createSetQueryOptionString does create a kv
string. Do you mean switching from using a Map of options to something like a
List<Pair<String, boolean>> ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
